-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements automatic-kubernetes-api-monitoring-cluster-name
feature flag
#797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismuellner
requested changes
May 24, 2022
0sewa0
reviewed
May 25, 2022
0sewa0
reviewed
May 25, 2022
meik99
previously requested changes
May 25, 2022
6c6e352
to
b56d666
Compare
automatic-kubernetes-api-monitoring-cluster-label
feature flagautomatic-kubernetes-api-monitoring-cluster-name
feature flag
chrismuellner
requested changes
May 25, 2022
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Show resolved
Hide resolved
Dismissing my review 'cause issues were fixed
chrismuellner
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AutomaticKubernetesApiMonitoring
feature usesclusterLabel
to show it on UI.By default
clusterLabel
is set todynakube
CR name.If
feature.dynatrace.com/automatic-kubernetes-api-monitoring-cluster-label
annotation is set, it's value is used to override default value ofclusterLabel
.Unicode characters are supported as a value.
How can this be tested?
check if UI shows:
![image](https://user-images.githubusercontent.com/35979436/170028823-b87dc2d1-6d61-4ea7-97d0-50661c2b15de.png)
Checklist