Update controller-gen to v0.9.0
#801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgrzybek
suggested changes
May 25, 2022
Co-authored-by: Michał Grzybek <35979436+mjgrzybek@users.noreply.github.com>
|
I don't think Makefile should install tools. I'd leave it just checking if tool is available. |
|
Those checks are generated when the project is generated with |
I agree, but I think the main purpose of it is for the CI |
|
Ok, so now let's just bump version and we can discuss it when refactoring Makefile. |
mjgrzybek
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CRD was generated using an outdated version of
controller-gen.Removed
+kubebuilder:validation:MaxProperties=1annotation forOneAgentSpecwhich as incompatible.How can this be tested?
Upgrade
controller-genand check if the generated CRD is the same:go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.0make manifestsChecklist