Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes reinvocation policy to be enabled by default #802

Merged
merged 5 commits into from
May 30, 2022
Merged

Changes reinvocation policy to be enabled by default #802

merged 5 commits into from
May 30, 2022

Conversation

meik99
Copy link
Contributor

@meik99 meik99 commented May 27, 2022

Description

Reinvocation of the webhook for already injected pods was disabled by default.
This change enables it by default.

How can this be tested?

  • Create a cluster and install Istio
  • Deploy the operator and a dynakube
  • Create a test-namespace and label it with istio-injection=enabled so that istio injects into pods
  • Deploy a sample app
  • Pods of your sample app should have an install-oneagent init container that includes an environment variable CONTAINER_X_NAME with the name of the istio sidecar as a value. E.g. CONTAINER_2_NAME: istio-proxy
  • Annotate the dynakube with the feature.dynatrace.com/disable-webhook-reinvocation-policy: true annotation
  • Delete the pods of your sample app
  • Pods of your sample app should have the mentioned environment variable missing

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@meik99
changes reinvocation annotation to be opt-out
64c1e21 
Signed-off-by: Michael Rynkiewicz <michael.rynkiewicz@dynatrace.com>
@meik99
removing debug log
396f218 
Signed-off-by: Michael Rynkiewicz <michael.rynkiewicz@dynatrace.com>
@meik99 meik99 added the core Changes to core functionality of the Operator label May 27, 2022
@meik99 meik99 requested a review from a team as a code owner May 27, 2022 09:04
mjgrzybek
mjgrzybek suggested changes May 27, 2022
View reviewed changes
src/api/v1beta1/feature_flags.go Outdated Show resolved Hide resolved
luhi-DT
luhi-DT previously requested changes May 27, 2022
View reviewed changes
src/api/v1beta1/feature_flags.go Outdated Show resolved Hide resolved
@meik99
Changes reinvocation feature flag description
ae760f7 
Signed-off-by: Michael Rynkiewicz <michael.rynkiewicz@dynatrace.com>
@meik99
Moved test constants
3899475 
Signed-off-by: Michael Rynkiewicz <michael.rynkiewicz@dynatrace.com>
@meik99 meik99 enabled auto-merge (squash) May 30, 2022 09:02
@meik99 meik99 dismissed luhi-DT’s stale review May 30, 2022 09:03

Dismissed because issues were addressed

@meik99 meik99 merged commit a015152 into master May 30, 2022
@meik99 meik99 deleted the feature/reinvocation-opt-out branch May 30, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhi-DT luhi-DT luhi-DT left review comments

@mjgrzybek mjgrzybek mjgrzybek approved these changes

Assignees
No one assigned
Labels
core Changes to core functionality of the Operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meik99 @mjgrzybek @luhi-DT