Move complicated makefile logic into separate scripts #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorcholski
force-pushed
the
feature/makefile-logic-in-separate-scripts
branch
from
4b08cb3
to
ec7052e
Compare
meik99
reviewed
Jun 1, 2022
0sewa0
approved these changes
Jun 2, 2022
aorcholski
force-pushed
the
feature/makefile-logic-in-separate-scripts
branch
from
82f0f21
to
681d982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation of kustomize/controller-gen commands and the 'bundle' target moved to shell scripts.
The command.sh script installs a command if the corresponding package is provided. It also returns the full command path if the command is found.
The contents of the 'bundle' target has been moved to bundle.sh script.
How can this be tested?
Manual test performed - outcome of 'make bundle' command has not changed.
Checklist
- [ ] Unit tests have been updated/added