Use apiReader in nodes controller where possible #808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces all the
client.Get(...)
to use anapiReader
instead.This is necessary because the
client
uses a cache when getting resources which is useful,however it does a bad job at keeping that cache up to date,
which is important for us to act accordingly and also to avoid errors such as:
(Also did a minor refactoring, spelling and fixes)
How can this be tested?
The bug is not easy to reproduce, that is why it gone unfixed for so long, it happens only rarely and it depends on the cache the
client
uses.A general test is that you deploy anything that has an OS OneAgent (classicFullstack or cloudNativeFullStack).
Then remove one of the nodes, when that is done in the UI the "bar" should turn to yellow instead of red.
Checklist