Fix data-ingests's endpoint.properties
secret handling
#809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Secret
dynatrace-data-ingest-endpoint
is now always generated nevertheless which ingestions are enabled.If no ingestion is enabled, secret's data contains an empty string, as expected.
Fixed bug causing permanent reconciliation which was caused by comparing
nil
and an empty map, assuming it's equal.How can this be tested?
Check if
dynatrace-data-ingest-endpoint
secret indeafult
namespace contains expected content.Dynakubes to be used:
statsd-ingest
capability enabledManiulate dynakubes with:
k -ndynatrace annotate dynakubes.dynatrace.com dk --overwrite feature.dynatrace.com/disable-metadata-enrichment=false
- no change should be observedk -ndynatrace annotate dynakubes.dynatrace.com dk --overwrite feature.dynatrace.com/disable-metadata-enrichment=true
- metrics ingest URL and token should be removed from the secret dataChecklist