Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-ingests's endpoint.properties secret handling #809

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

mjgrzybek
Copy link
Contributor

@mjgrzybek mjgrzybek commented Jun 2, 2022

Description

  1. Secret dynatrace-data-ingest-endpoint is now always generated nevertheless which ingestions are enabled.
    If no ingestion is enabled, secret's data contains an empty string, as expected.

  2. Fixed bug causing permanent reconciliation which was caused by comparing nil and an empty map, assuming it's equal.

How can this be tested?

Check if dynatrace-data-ingest-endpoint secret in deafult namespace contains expected content.

Dynakubes to be used:

  1. default one, with no annotation
  2. with AG statsd-ingest capability enabled

Maniulate dynakubes with:

  1. k -ndynatrace annotate dynakubes.dynatrace.com dk --overwrite feature.dynatrace.com/disable-metadata-enrichment=false - no change should be observed
  2. k -ndynatrace annotate dynakubes.dynatrace.com dk --overwrite feature.dynatrace.com/disable-metadata-enrichment=true - metrics ingest URL and token should be removed from the secret data

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek requested a review from a team as a code owner June 2, 2022 08:18
@chrismuellner chrismuellner added the bug Something isn't working label Jun 2, 2022
@mjgrzybek mjgrzybek force-pushed the bugfix/endpointproperties-master branch from 0df2afe to e77d088 Compare June 2, 2022 08:31
@mjgrzybek mjgrzybek enabled auto-merge (squash) June 2, 2022 09:01
@mjgrzybek mjgrzybek force-pushed the bugfix/endpointproperties-master branch from 2b87b93 to 914f0c4 Compare June 2, 2022 09:41
src/ingestendpoint/secret.go Show resolved Hide resolved
src/ingestendpoint/secret.go Outdated Show resolved Hide resolved
@mjgrzybek mjgrzybek merged commit 1a1c32a into master Jun 2, 2022
@mjgrzybek mjgrzybek deleted the bugfix/endpointproperties-master branch June 2, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants