Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move github actions bash scripts into separate files #814

Merged
merged 4 commits into from
Jun 3, 2022

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Jun 2, 2022

Description

Bash scripts are defined in the yaml file of the Actions directly. This means there's no syntax highlighting and testing them is problematic.

Therefore we moved ci scripts to dedicated shell files.

How can this be tested?

Look on our action pipeline, if it still works.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@gkrenn gkrenn marked this pull request as ready for review June 2, 2022 14:46
@gkrenn gkrenn requested a review from a team as a code owner June 2, 2022 14:46
@gkrenn gkrenn added the ci Updates to the pipeline label Jun 2, 2022
.github/workflows/ci.yaml Show resolved Hide resolved
hack/build/ci/prepare-build-variables.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
hack/build/ci/create-manifest.sh Outdated Show resolved Hide resolved
hack/build/ci/create-manifest.sh Outdated Show resolved Hide resolved
@chrismuellner chrismuellner changed the title Move scripts into files Move github actions bash scripts into separate files Jun 3, 2022
Co-authored-by: Michael Rynkiewicz <michael.rynkiewicz@dynatrace.com>
@gkrenn gkrenn requested a review from meik99 June 3, 2022 07:38
@gkrenn gkrenn enabled auto-merge (squash) June 3, 2022 09:27
@gkrenn gkrenn merged commit 753aa96 into master Jun 3, 2022
@gkrenn gkrenn deleted the feature/move-ci-logic-to-file2 branch June 3, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Updates to the pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants