Readds separate proxy key to the init secret #839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
proxy
field in the init secret was moved under theconfig
field (which is a json).This broke how the webhook injects the
DT_PROXY
envvar to the customer's pod.And to avoid the need to directly read the secret in the webhook during injection, this adds the
proxy
field back as its separate field.This duplicates the
proxy
value inside the init secret, however this is a far nicer way than reading the secret for every pod injection.How can this be tested?
Use a dynakube that has proxy set, and you can check:
dynatrace-dynakube-config
in the sample app namespace has theproxy
fieldDT_PROXY
is setChecklist