Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readds separate proxy key to the init secret #839

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jun 21, 2022

Description

The proxy field in the init secret was moved under the config field (which is a json).
This broke how the webhook injects the DT_PROXY envvar to the customer's pod.

And to avoid the need to directly read the secret in the webhook during injection, this adds the proxy field back as its separate field.
This duplicates the proxy value inside the init secret, however this is a far nicer way than reading the secret for every pod injection.

How can this be tested?

Use a dynakube that has proxy set, and you can check:

  • the dynatrace-dynakube-config in the sample app namespace has the proxy field
  • exec into the sample pod, check if DT_PROXY is set
  • everything works as normal

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@0sewa0 0sewa0 added the bug Something isn't working label Jun 21, 2022
@0sewa0 0sewa0 requested a review from a team as a code owner June 21, 2022 09:32
@0sewa0 0sewa0 merged commit 1f2db42 into release-0.7 Jun 21, 2022
@0sewa0 0sewa0 deleted the bug/fix-proxy-field-in-init-secret branch June 21, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants