Set default value for version label when custom image is used #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
reviewed
Jun 22, 2022
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
meik99
suggested changes
Jun 22, 2022
There was a problem hiding this comment.
An image is apparently not a valid label value
{"error":"StatefulSet.apps \"dynakube-activegate\" is invalid: [metadata.labels: Invalid value: \"API_URL/linux/activegate:latest\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')
meik99
suggested changes
Jun 23, 2022
mjgrzybek
previously requested changes
Jun 28, 2022
meik99
suggested changes
Jun 28, 2022
mjgrzybek
reviewed
Jun 28, 2022
0sewa0
force-pushed
the
fix/use-image-for-label
branch
from
9d90c30
to
c54b37c
Compare
0sewa0
changed the title
0sewa0
force-pushed
the
fix/use-image-for-label
branch
from
268cc83
to
4c9d6f2
Compare
0sewa0
changed the title
meik99
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting the version label for components managed by the operator (oneagent and activegate) the latest version on the cluster is used instead of the tag of the image in case an image is used.Now when an image is used for activegate or oneagent, we use its tag as value for theapp.kubernetes.io/versionlabel.To not to confuse the customer when using custom image, the version label is set to a default value of
custom-image.Using the image tag is not reliable/safe (it can be longer then the max label value)
How can this be tested?
Deploy a dynakube where the oneagent/activegate image field is set, and see that the deployed daemonset/statefulset has the correct labels
Checklist