Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use empty proxy password (backport to release-0.7) #907

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Allow to use empty proxy password (backport to release-0.7) #907

merged 2 commits into from
Jun 29, 2022

Conversation

aorcholski
Copy link
Contributor

Clients use proxies with empty proxy password. A CR is accepted by the proxy_url validator if proxy password is empty.

How can this be tested?
Use empty password in the Proxy Url (proxy.value, proxy secret) and try to apply your CR - should be accepted.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly
  • I have read and understood the contribution guidelines

@aorcholski aorcholski added the bug Something isn't working label Jun 29, 2022
@aorcholski aorcholski requested a review from a team as a code owner June 29, 2022 11:51
@chrismuellner chrismuellner added cherrypick Cherrypicked changes that already exist in a different PR and removed bug Something isn't working labels Jun 29, 2022
@aorcholski aorcholski merged commit abdbf89 into release-0.7 Jun 29, 2022
@aorcholski aorcholski deleted the bugfix/empty-proxy-password-0.7 branch June 29, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meik99 meik99 meik99 approved these changes

Assignees
No one assigned
Labels
cherrypick Cherrypicked changes that already exist in a different PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aorcholski @meik99 @chrismuellner