Makes standalone init env requirements injection specific #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
changed the title
chrismuellner
requested changes
Jul 4, 2022
meik99
approved these changes
Jul 5, 2022
chrismuellner
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The standalone init wants to read/setup envvars that are not necessary for data-ingest only injection, which the webhook will not provide ==> standalone init fails the pod
Now it only sets env fields to be required according to what injection is needed.
How can this be tested?
Inject into a:
all of these should work as expected
Checklist
[ ] Unit tests have been updated/added