Add configurable labels and annotations sections for operator components in helm-charts #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
requested changes
Jul 7, 2022
|
you could add helm unit-tests for this 😉 |
0sewa0
previously approved these changes
Jul 7, 2022
0sewa0
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
values.yamlfile in the sections of the operator components custom annotations and labels can be added by adding them to the empty array. They should then be visible in the rendered chart. They are simply added to the default labels and annotations.How can this be tested?
Go into the
values.yamlfile and add custom labels or annotations, render the helm-chart and check, whether the labels or annotations are there or not.Checklist