Use latest version endpoint for agent download #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkrenn
reviewed
Jul 8, 2022
| @@ -32,12 +32,14 @@ func SetDynakubeStatus(instance *dynatracev1beta1.DynaKube, opts Options) error | |||
| return errors.WithStack(err) | |||
| } | |||
|
|
|||
| latestAgentVersionUnixDefault, err := dtc.GetLatestAgentVersion(dtclient.OsUnix, dtclient.InstallerTypeDefault) | |||
| latestAgentVersionUnixDefault, err := dtc.GetLatestAgentVersion( | |||
| dtclient.OsUnix, dtclient.InstallerTypeDefault) | |||
There was a problem hiding this comment.
We could acutally remove UnixDefault as we never use it anywhere
gkrenn
approved these changes
Jul 8, 2022
chrismuellner
added a commit
that referenced
this pull request
Jul 11, 2022
Closed
0sewa0
pushed a commit
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom version defined on the Tenant was ignored in favor of latest available version.
How can this be tested?
Change what oneagent version is used from latest on the Tenant and check correct version of code modules is downloaded.
Checklist