Add labelSelector to webhook's topologySpreadConstraints
#938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
approved these changes
Jul 8, 2022
|
should manifests be updated? |
chrismuellner
requested changes
Jul 8, 2022
mjgrzybek
force-pushed
the
bugfix/add-labelselector-to-topologyspreadconstraints
branch
from
066575f
to
fb03023
Compare
chrismuellner
approved these changes
Jul 11, 2022
mjgrzybek
deleted the
bugfix/add-labelselector-to-topologyspreadconstraints
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Webhook's deployment is missing
labelSelectorintopologySpreadConstraints.As an effect,
topologySpreadConstraintsis not applied.How can this be tested?
Deploy dynatrace-operator with default settings.
Watch
kube-schedulerlogs.Scale webhook deployment up and down multiple times and observe if pods are spread across nodes evenly.
Checklist