Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code modules image download loop #958

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Fix code modules image download loop #958

merged 2 commits into from
Jul 12, 2022

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Jul 12, 2022

Description

If the custom code modules image field is set, our CSI driver downloads the oneagent by using the custom docker image. Due to a bug, the image was downloaded on every reconciliation.

How can this be tested?

Start application monitoring with custom code modules image and check if "image is already installed" is in the log messages of the csi driver pod.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly
  • I have read and understood the contribution guidelines

@gkrenn gkrenn added the bug Something isn't working label Jul 12, 2022
@gkrenn gkrenn requested a review from a team as a code owner July 12, 2022 13:23
@gkrenn gkrenn enabled auto-merge (squash) July 12, 2022 16:28
@gkrenn gkrenn merged commit eab9f10 into master Jul 12, 2022
@gkrenn gkrenn deleted the fix/code-modules-image branch July 12, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants