Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves isAlreadyDownloaded for ImageInstaller #966

Merged
merged 6 commits into from
Jul 13, 2022
Merged

Improves isAlreadyDownloaded for ImageInstaller #966

merged 6 commits into from
Jul 13, 2022

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jul 13, 2022

Description

The ImageInstaller's check isAlreadyDownloaded didn't consider that there might have been other Dynakubes that have already downloaded the image, which caused unnecessary downloads.

How can this be tested?

Have 2 Dynakubes, both use the same codeModulesImage.

  1. Dynakube gets reconciled by the csi-driver provisioner ==> image gets downloaded
  2. Dynakube gets reconciled by the csi-driver provisioner ==> image DOESN'T get downloaded, because its already present

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly
  • I have read and understood the contribution guidelines

@0sewa0 0sewa0 added the bug Something isn't working label Jul 13, 2022
@0sewa0 0sewa0 requested a review from a team as a code owner July 13, 2022 11:38
chrismuellner
chrismuellner requested changes Jul 13, 2022
View reviewed changes
src/installer/image/installer.go Outdated Show resolved Hide resolved
src/installer/image/installer.go Outdated Show resolved Hide resolved
src/controllers/csi/metadata/sqlite.go Outdated Show resolved Hide resolved
src/installer/image/installer.go Outdated Show resolved Hide resolved
src/installer/image/installer.go Show resolved Hide resolved
@0sewa0 0sewa0 enabled auto-merge (squash) July 13, 2022 13:57
@0sewa0 0sewa0 merged commit 08bb746 into master Jul 13, 2022
@0sewa0 0sewa0 deleted the fix/repeated-image-download branch July 13, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismuellner chrismuellner chrismuellner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0sewa0 @chrismuellner