Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config to work with v1beta1 changes #143

Merged
merged 15 commits into from
Oct 28, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Oct 18, 2021

  • Updates the config files for the dynatrace-operator to match the ones on dynatrace-operator/master.
  • Updates the values.yaml to match the v1beta1 CR
  • Updates questions.yaml for Rancher

@0sewa0 0sewa0 marked this pull request as ready for review October 21, 2021 10:24
Copy link
Collaborator

@chrismuellner chrismuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer have a Dynakube when upgrading from v0.2.2 with v1alpha1 to the local version with v1beta1 via the helm upgrade dynatrace-operator "helm-charts/dynatrace-operator/chart/default" -n dynatrace --reuse-values command.

It tries to apply the following manifest (not relevant sections removed):

# Source: dynatrace-operator/templates/Common/customresource-dynakube.yaml
# Copyright 2020 Dynatrace LLC
...
apiVersion: dynatrace.com/v1beta1
kind: DynaKube
metadata:
...
spec:
  apiUrl: <removed>

  tokens: dynakube

  oneAgent:
    classicFullStack:

      autoUpdate: 
  kubernetesMonitoring:
    enabled: true
    replicas: 1
  routing:
    enabled: true
    replicas: 1

This is not recognized as a valid object by Kubernetes and fails to apply, since autoUpdate does not have a value.

@chrismuellner chrismuellner merged commit c524918 into master Oct 28, 2021
@chrismuellner chrismuellner deleted the feature/update-for-v1beta1 branch October 28, 2021 13:53
@luhi-DT luhi-DT added the enhancement New feature or request label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants