Code review [#25] P1 - Retrofit creator.

E-D-W-I-N · May 16, 2021 · 8660717 · 8660717
1 parent ac39fa0
commit 8660717
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 15 deletions.
diff --git a/.idea/runConfigurations.xml b/.idea/runConfigurations.xml
diff --git a/app/build.gradle b/app/build.gradle
@@ -57,10 +57,6 @@ dependencies {
     // Koin
     implementation "io.insert-koin:koin-android:$koin_version"
 
-    // Retrofit + GSON
-    implementation "com.squareup.retrofit2:retrofit:$retrofit_version"
-    implementation "com.squareup.retrofit2:converter-gson:$retrofit_version"
-
     // Location
     implementation "com.google.android.gms:play-services-location:$playServicesLocation_version"
 

diff --git a/app/src/main/java/com/edwin/weatherapp/di/AppModule.kt b/app/src/main/java/com/edwin/weatherapp/di/AppModule.kt
@@ -3,7 +3,7 @@ package com.edwin.weatherapp.di
 import android.location.Geocoder
 import com.edwin.data.device.GetLocationDataSource
 import com.edwin.data.network.GeocoderDataSource
-import com.edwin.data.network.WeatherApiDataSource
+import com.edwin.data.network.RetrofitClient
 import com.edwin.data.repository.WeatherRepositoryImpl
 import com.edwin.domain.WeatherRepository
 import com.edwin.domain.usecase.GetAddressFromGeocoderUseCase
@@ -15,17 +15,8 @@ import com.google.android.gms.location.LocationServices
 import org.koin.android.ext.koin.androidContext
 import org.koin.androidx.viewmodel.dsl.viewModel
 import org.koin.dsl.module
-import retrofit2.Retrofit
-import retrofit2.converter.gson.GsonConverterFactory
 
 val dataModule = module {
-    // Retrofit API
-    single {
-        Retrofit.Builder()
-            .baseUrl("https://api.openweathermap.org/data/2.5/")
-            .addConverterFactory(GsonConverterFactory.create())
-            .build().create(WeatherApiDataSource::class.java)
-    }
 
     // FusedLocationProvider
     single { LocationServices.getFusedLocationProviderClient(androidContext()) }
@@ -40,7 +31,13 @@ val dataModule = module {
     single { GeocoderDataSource(get()) }
 
     // WeatherRepository
-    single<WeatherRepository> { WeatherRepositoryImpl(get(), get(), get()) }
+    single<WeatherRepository> {
+        WeatherRepositoryImpl(
+            RetrofitClient.weatherDataSource,
+            get(),
+            get()
+        )
+    }
 }
 
 val useCaseModule = module {

diff --git a/data/src/main/java/com/edwin/data/network/RetrofitClient.kt b/data/src/main/java/com/edwin/data/network/RetrofitClient.kt
@@ -0,0 +1,20 @@
+package com.edwin.data.network
+
+import retrofit2.Retrofit
+import retrofit2.converter.gson.GsonConverterFactory
+
+object RetrofitClient {
+
+    private const val BASE_URL = "https://api.openweathermap.org/data/2.5/"
+
+    private val retrofit: Retrofit by lazy {
+        Retrofit.Builder()
+            .addConverterFactory(GsonConverterFactory.create())
+            .baseUrl(BASE_URL)
+            .build()
+    }
+
+    val weatherDataSource: WeatherApiDataSource by lazy {
+        retrofit.create(WeatherApiDataSource::class.java)
+    }
+}