Makefile updates to fix parallel build failures #4948
Conversation
Update object file dependency definitions in src/mode_init/Makefile and src/shared/Makefile to resolve build errors that occur when building ocean_model with multiple jobs (i.e. 'make -j')
There was a problem hiding this comment.
@brian-oneill - Thanks for updating these. While testing, I ran into another dependency so I grep'd on "use ocn_" in the src/shared directory and updated the Makefile there with all of the use-based dependencies. With that version, everything worked fine. I pushed that onto my fork of E3SM in a branch of the same name (philipwjones:brian-oneill/ocean/makefile-updates ) so you can either just copy that version of the shared Makefile, merge my version into yours or however you want to do it. Then this should be good to go.
|
@philipwjones committed new changes to match your fork. Thanks for more thoroughly going through the dependencies. |
There was a problem hiding this comment.
Great, thanks @brian-oneill Approved based on quick QU240 tests and successful parallel builds across supported machines.
Makefile updates to fix parallel build failures Update object file dependency definitions in src/mode_init/Makefile and src/shared/Makefile to resolve build errors that occur when building ocean_model with multiple jobs (i.e. 'make -j'). Only used by the standalone model, so no impact on E3SM [BFB]
|
Passes sanity testing, merged to next |
|
merged to master |
Update object file dependency definitions in src/mode_init/Makefile and src/shared/Makefile to resolve build errors that occur when building ocean_model with multiple jobs (i.e. 'make -j').
Confirmed successful parallel build from scratch on Summit, Cori, and Chrysalis. No edits to code execution.
[BFB]