Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up 3 warnings/errors in ocean registry files #4974

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented May 22, 2022

These errors are harmless in E3SM but lead to the following messages during MPAS-Ocean compilation:

Reading registry file from standard input
WARNING: time_levs attribute on var isomip_bottomPressure in var_struct scratch is 0. It will be replaced with 1.
Warning: runtime_format attribute has no effect for immutable stream "conservationCheckRestart".
ERROR: Dimension time on variable sedimentFallVelocity doesn't exist.

The registry for the conservation check analysis member is the only one of these 3 that might be on in E3SM. By removing the runtime_format attribute as I have done here, we get the same behavior as before, as the message above indicates.

The ISOMIP registry is only used in the standalone ocean model (and only in init mode for that particular test case).

The sediment transport analysis member is off by default in E3SM.

@xylar xylar added mpas-ocean BFB PR leaves answers BFB labels May 22, 2022
@xylar xylar requested a review from mark-petersen May 22, 2022 20:32
@xylar xylar assigned xylar and jonbob and unassigned xylar May 22, 2022
@xylar
Copy link
Contributor Author

xylar commented May 22, 2022

Testing

I have made sure I could compile the code as before but that the 3 warnings/errors no longer appear.

I ran the ocean pr compass suite on Anvil with Intel and Intel-MPI. The results are BFB as expected.

@mark-petersen, when you have time, could you run the nightly test suite somewhere to make sure everything is fine?

@jonbob, I don't expect any E3SM changes. I think the usual tests you run before merging to next should be sufficient in this trivial case.

@xylar xylar changed the title Clean up 3 errors in ocean registry files Clean up 3 warnings/errors in ocean registry files May 23, 2022
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar thanks for the cleanup! I compiled with gnu and intel, debug and optimized, and ran the nightly suite with gnu optimized and it is bfb with master.

I mentioned adding to this, but I'll do that on a different PR.

jonbob added a commit that referenced this pull request Jun 6, 2022
Clean up 3 warnings/errors in ocean registry files

These errors are harmless in E3SM but lead to error messages during
MPAS-Ocean standalone compilation. The registry for the conservation
check analysis member is the only one of these 3 that might be on in
E3SM. By removing the runtime_format attribute we get the same behavior
as before. The ISOMIP registry is only used in the standalone ocean model
(and only in init mode for that particular test case). The sediment
transport analysis member is off by default in E3SM.

[BFB]
@jonbob jonbob merged commit a3c96cd into E3SM-Project:master Jun 7, 2022
@jonbob
Copy link
Contributor

jonbob commented Jun 7, 2022

merged to master

@xylar xylar deleted the ocn/clean-up-registry-errors branch June 7, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants