Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigzag Strategy just open buy positon ,not sell #5

Open
mavidelisi opened this issue Aug 7, 2023 · 2 comments
Open

Zigzag Strategy just open buy positon ,not sell #5

mavidelisi opened this issue Aug 7, 2023 · 2 comments
Labels

Comments

@mavidelisi
Copy link

Hi Kenorb ;

when i test robot for zigzag strategy regardless timeframe , it just open buy position , not sell position.

Thanks.

@kenorb
Copy link
Member

kenorb commented Aug 16, 2023

Thanks for the report.

EA Advanced v2.013.1 with MT5:

  • Tested ZigZag assigned on M15-H12 timeframes with default settings on EURUSD for this year, it generates a lot of trades, all longs.

So you're right, something is off.

I've checked MT4 tests for ZigZag strategy, same issue for MT4:

Symbol                             EURUSD (Euro vs US Dollar)
Period                             1 Minute (M1) 2019.01.01 23:42 - 2019.01.30 23:59 (2019.01.01 - 2019.01.31)
Total trades                  1934 Short positions (won %)                  0 (0.00%) Long positions (won %)                             1934 (49.69%)

Signal logic can be found at https://github.com/EA31337/Strategy-ZigZag/blob/v1.013/Stg_ZigZag.mqh#L107-L116

I'll check and fix it in the next release.

@kenorb kenorb transferred this issue from EA31337/EA31337 Aug 17, 2023
@kenorb
Copy link
Member

kenorb commented Aug 17, 2023

Fixed in a6f505e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants