[ci] release 워크플로 수정
#148
[ci] release 워크플로 수정
#148
Conversation
EATSTEAK
added
bug
|
Warning Rate limit exceeded@EATSTEAK has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe pull request focuses on modifying GitHub Actions workflow configurations across three files: Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
EATSTEAK
force-pushed
the
ci/fix-release
branch
from
5ec614b to
8f9e384
Compare
EATSTEAK
force-pushed
the
ci/fix-release
branch
from
8f9e384 to
dedb1ab
Compare
EATSTEAK
force-pushed
the
ci/fix-release
branch
from
dedb1ab to
3c55667
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/release.yml (1)
Line range hint
18-42: Consider optimizing version check and token usageA few suggestions for improving this section:
- Consider using
gh api repos/:owner/:repo/releases/latestinstead of fetching all releases and taking the first one- Consider using different tokens for checkout vs API operations (principle of least privilege)
Here's an optimized version of the version check:
- name: Fetch latest release tag id: latest_release run: | curl -L \ -H "Accept: application/vnd.github+json" \ - -H "Authorization: Bearer ${{ secrets.IOS_GITHUB_TOKEN }}" \ + -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \ -H "X-GitHub-Api-Version: 2022-11-28" \ - https://api.github.com/repos/EATSTEAK/rusaint/releases \ - | jq '.[0].tag_name | "result=" + .' \ + https://api.github.com/repos/EATSTEAK/rusaint/releases/latest \ + | jq '.tag_name | "result=" + .' \ | tr -d '"' >> $GITHUB_OUTPUT🧰 Tools
🪛 yamllint (1.35.1)
[warning] 3-3: truthy value should be one of [false, true]
(truthy)
[error] 5-5: too many spaces inside brackets
(brackets)
[error] 5-5: too many spaces inside brackets
(brackets)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/build_test.yml(0 hunks).github/workflows/lint.yml(0 hunks).github/workflows/release.yml(1 hunks)
💤 Files with no reviewable changes (2)
- .github/workflows/build_test.yml
- .github/workflows/lint.yml
🔇 Additional comments (1)
.github/workflows/release.yml (1)
Line range hint 52-53: LGTM! Cache configuration simplification
The removal of explicit cache configuration aligns with similar changes in other workflow files, simplifying the caching mechanism while maintaining functionality.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 3-3: truthy value should be one of [false, true]
(truthy)
[error] 5-5: too many spaces inside brackets
(brackets)
[error] 5-5: too many spaces inside brackets
(brackets)
.github/workflows/release.yml
Outdated
| paths: | ||
| - './Cargo.toml' |
There was a problem hiding this comment.
Fix the path filter syntax
The path filter syntax is incorrect. In GitHub Actions, paths should be specified relative to the repository root without leading ./.
Apply this diff to fix the path filter:
paths:
- - './Cargo.toml'
+ - 'Cargo.toml'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| paths: | |
| - './Cargo.toml' | |
| paths: | |
| - 'Cargo.toml' |
What's in this pull request
release워크플로가 동작하지 않는 문제 수정Summary by CodeRabbit
Cargo.tomlfile.