[fix] 겨울학기의 key가 잘못 입력됨

[EATSTEAK]

What's in this pull request

• 겨울학기(SemesterType::Winter)의 key가 잘못 입력되어 파싱하지 못하는 현상 수정

Summary by CodeRabbit

• Bug Fixes

  • Updated error handling in the classes_with_detail test to prevent panics when no class with detail is found.

• Changes

  • Adjusted the mapping for the winter semester from "0923" to "093" across multiple applications, affecting how the winter semester is represented.

[coderabbitai]

Walkthrough

The pull request introduces a consistent modification across multiple application modules in the rusaint package. Specifically, the semester_to_key function in different application structs (Chapel, CourseGrades, LectureAssessment, and PersonalCourseSchedule) has been updated to change the winter semester key from "0923" to "093". Additionally, the course grades test file has been updated with improved error handling in the classes_with_detail test function to prevent potential panics.

Changes

File	Change Summary
packages/rusaint/src/application/*/mod.rs	Updated semester_to_key function to return "093" instead of "0923" for SemesterType::Winter in multiple application modules
packages/rusaint/tests/application/course_grades.rs	Enhanced error handling in classes_with_detail test function by adding a check for None before unwrapping detail_code

Suggested Labels

breaking

Poem

🐰 A Semester's Whisper

From "0923" to "093" we leap,
Winter's key, no longer deep
Rusaint's modules dance and sway
With precision, come what may
A rabbit's code, both swift and bright! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6aa8201 and ea03366.

📒 Files selected for processing (5)

• packages/rusaint/src/application/chapel/mod.rs (1 hunks)
• packages/rusaint/src/application/course_grades/mod.rs (1 hunks)
• packages/rusaint/src/application/lecture_assessment/mod.rs (1 hunks)
• packages/rusaint/src/application/personal_course_schedule/mod.rs (1 hunks)
• packages/rusaint/tests/application/course_grades.rs (1 hunks)

🔇 Additional comments (5)

packages/rusaint/tests/application/course_grades.rs (1)

78-82: Improved error handling for missing class details

Good addition of defensive programming to handle the case when no classes with details are found. The informative logging helps with debugging.

packages/rusaint/src/application/chapel/mod.rs (1)

50-50: Winter semester key fix looks good

The change from "0923" to "093" for SemesterType::Winter aligns with the PR objective.

Let's verify the consistency of this change across all semester key implementations:

✅ Verification successful

Winter semester key is consistently implemented as "093" across all modules

The verification shows that all five Rust modules in the codebase use the same "093" key for SemesterType::Winter:

• packages/rusaint/src/application/lecture_assessment/mod.rs
• packages/rusaint/src/application/course_grades/mod.rs
• packages/rusaint/src/application/chapel/mod.rs
• packages/rusaint/src/application/course_schedule/mod.rs
• packages/rusaint/src/application/personal_course_schedule/mod.rs

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify winter semester key implementation across all files
# Expected: All winter semester keys should be "093"

echo "Checking winter semester key implementations..."
rg -A 4 'SemesterType::Winter =>' --type rust

Length of output: 2056

packages/rusaint/src/application/lecture_assessment/mod.rs (1)

67-67: Winter semester key change maintains logical sequence

The change from "0923" to "093" for SemesterType::Winter aligns with the PR objective and maintains a logical sequence with other semester keys (090 → 091 → 092 → 093).

packages/rusaint/src/application/course_grades/mod.rs (1)

116-116: LGTM: Consistent semester key update

The change from "0923" to "093" for winter semester:

1. Fixes the reported key input issue
2. Maintains consistency with other semester keys
3. Matches the change in other modules

packages/rusaint/src/application/personal_course_schedule/mod.rs (1)

50-50: LGTM! Verify consistency across modules.

The change from "0923" to "093" for winter semester follows a logical sequential pattern with other semester keys (090, 091, 092, 093).

Let's verify the consistency of this change across other modules:

✅ Verification successful

Change is consistent across all modules ✅

The winter semester key "093" is consistently implemented across all relevant modules in the application:

• personal_course_schedule/mod.rs
• lecture_assessment/mod.rs
• course_grades/mod.rs
• chapel/mod.rs
• course_schedule/mod.rs

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check semester key implementation across all modules
# Expect: All winter semester keys should be "093"

rg -A 4 "SemesterType::Winter =>" packages/rusaint/src/application/

Length of output: 1973

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.