Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityのSetterの一部に戻り値がなかったので追加 / コメントの誤植修正 #156

Merged
merged 2 commits into from
Aug 17, 2022
Merged

EntityのSetterの一部に戻り値がなかったので追加 / コメントの誤植修正 #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa10180
Entityのsetterの一部に戻り値を追加
kazuyoshikakihara Aug 14, 2022
ba94b5c
コメントの誤植を修正
kazuyoshikakihara Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Entity/Coupon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,14 @@ public function getCouponMember()

/**
* @param bool $couponMember
*
* @return Coupon
*/
public function setCouponMember($couponMember)
{
$this->coupon_member = $couponMember;

return $this;
}

/**
Expand All @@ -557,10 +561,14 @@ public function getCouponLowerLimit()

/**
* @param int $couponLowerLimit
*
* @return Coupon
*/
public function setCouponLowerLimit($couponLowerLimit)
{
$this->coupon_lower_limit = $couponLowerLimit;

return $this;
}

/**
Expand All @@ -573,9 +581,13 @@ public function getCouponRelease()

/**
* @param int $coupon_release
*
* @return Coupon
*/
public function setCouponRelease($coupon_release)
{
$this->coupon_release = $coupon_release;

return $this;
}
}
2 changes: 1 addition & 1 deletion Service/PurchaseFlow/Processor/CouponProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ private function removeCouponDiscountItem(ItemHolderInterface $itemHolder, Coupo
*
* 値引額の場合の計算方法
* クーポンで設定した価格で、クーポン値引の明細を生成する(税込価格、税率0%、課税)
* 税込1080円の商品に、1000円のクーポンを使用すると、980円の支払いになるイメージ
* 税込1080円の商品に、100円のクーポンを使用すると、980円の支払いになるイメージ
*
* 明細ごとに税込の値引額を集計し、クーポン値引の明細を生成する(税込価格、税率0%、課税)
* 軽減税率適用により税率が混在する場合もあるため、税込価格、税率0%で明細を生成する
Expand Down