クーポン削除モーダルのメッセージ表示をEC-CUBE本体に合わせた #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryo-endo
commented
Aug 27, 2022
| @@ -95,13 +95,13 @@ | |||
| <div class="modal-dialog" role="document"> | |||
| <div class="modal-content"> | |||
| <div class="modal-header"> | |||
| <h5 class="modal-title font-weight-bold"> | |||
| {{ 'plugin_coupon.admin.index.delete.confirm'|trans }}</h5> | |||
| <h5 class="modal-title fw-bold"> | |||
There was a problem hiding this comment.
bootstrap5対応漏れてたみたいです。
ryo-endo
commented
Aug 27, 2022
| @@ -14,7 +14,8 @@ plugin_coupon.admin.index.col09: 有効期間 | |||
| plugin_coupon.admin.index.col10: 編集 | |||
| plugin_coupon.admin.index.col11: 状態 | |||
| plugin_coupon.admin.index.col12: 削除 | |||
| plugin_coupon.admin.index.delete.confirm: このクーポンを削除しても宜しいですか？ | |||
| plugin_coupon.admin.index.delete__confirm_title: クーポンを削除します | |||
| plugin_coupon.admin.index.delete__confirm_message: クーポンを削除してよろしいですか？ | |||
There was a problem hiding this comment.
nanasess
approved these changes
Aug 30, 2022
chihiro-adachi
added
bugbounty2022:pr:entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
クーポン削除時に表示されるモーダルのメッセージ内容とレイアウトが、EC-CUBE本体と統一できていなかったのを修正しました。
修正前
修正後
参考：商品削除