Docker Composeの各種定義を.envに移行 + DB GUIツール追加 #4397
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#4391
先日の状態からdocker-compose周りの構造(環境変数指定の仕方やDB情報)を変更していますが、まだ日が浅い今のうちに整理しておきたいと考えた次第です。
方針(Policy)
EC_CUBEで使用する
DATABASE_URL
等を、MYSQL_DATABASE
等の環境変数から構築するか少し迷いましたが、複雑になるため見送りました実装に関する補足(Appendix)
テスト(Test)
docker-compose down -v
でVolumeを落とし、docker-compsoe up -d
で再初期化compose run-script compile
によるDBスキーマ作成ができること相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目