Symfony6対応 #6073
Merged
Symfony6対応 #6073
+13,033
−7,385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration. Replace `class_name` with `actor` in config to fix this
… with Codeception\Actor::getScenario()
…t) must be of type int, null given
… ($string) must be of type string, float given
…ing, int given
…nent to be installed. Try running "composer require symfony/lock".
…ntains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Symfony\Component\Security\Core\User\UserProviderInterface::loadUserByIdentifier)
…, register a listener on the LogoutEvent event instead."
…oles() must be compatible with Symfony\Component\Security\Core\User\UserInterface::getRoles(): array
…thod and must therefore be declared abstract or implement the remaining methods (Symfony\Component\Security\Core\User\UserInterface::getUserIdentifier)
…inFailureEvent instead"
…nt of SessionTokenStorage, inject a \Symfony\Component\HttpFoundation\RequestStack $requestStack instead"
…nt\DependencyInjection\ContainerInterface aliases of the service_container service, configure them explicitly instead."
…nt of SessionTokenStorage, inject a \Symfony\Component\HttpFoundation\RequestStack $requestStack instead"
…factory.generic service, the security.encoder_factory and Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface"
…argument "$serviceContainer" of method "__construct()" references interface "Symfony\Component\DependencyInjection\ContainerInterface" but no such service exists. You should maybe alias this interface to the existing "service_container" service."
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6073 +/- ##
============================================
+ Coverage 82.69% 82.78% +0.08%
- Complexity 6466 6509 +43
============================================
Files 477 479 +2
Lines 25953 26029 +76
============================================
+ Hits 21462 21547 +85
+ Misses 4491 4482 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nt\DependencyInjection\ContainerInterface aliases of the service_container service, configure them explicitly instead."
chihiro-adachi
requested review from
kiy0taka,
shinya,
dotani1111 and
ji-eunsoo
nanasess
requested changes
Jan 31, 2024
Closed
nanasess
previously approved these changes
Feb 6, 2024
|
2月末ぐらいを目処に、mergeしていきたいと思います。 |
nanasess
previously approved these changes
Feb 21, 2024
dotani1111
previously approved these changes
Feb 21, 2024
chihiro-adachi
dismissed stale reviews from dotani1111 and nanasess
via
235143d
dotani1111
approved these changes
Feb 26, 2024
shinya
approved these changes
Feb 26, 2024
ji-eunsoo
approved these changes
Feb 26, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#6069 のシステム要件・フレームワークの更新に対応
アップデートするパッケージ
#6069 を参照
削除されるパッケージ
主な変更点
TODO
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
github actionsは一通りパス
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目