GitHub Actions で PostgreSQL がエラーになるのを修正 #1018
Open
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL17 サーバーへ PostgreSQL17未満の psql で `\l` を実行すると以
下のエラーが発生する
```
psql --version
psql (PostgreSQL) 16.4
psql -h 127.0.0.1 -p 15432 -U eccube_db_user eccube_db
eccube_db=# \l
ERROR: column d.daticulocale does not exist
行 8: d.daticulocale as "ICU Locale",
^
HINT: Perhaps you meant to reference the column "d.datlocale".
```
副作用の少ない `SELECT 1` に変更する.
また、 docker compose のヘルえスチェックが有効になるよう `condition: service_healthy` を追加する
|
個人アカウントで確認するかぎりは PostgreSQL17 でも問題なさそう |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
=======================================
Coverage 56.29% 56.29%
=======================================
Files 75 75
Lines 8917 8917
=======================================
Hits 5020 5020
Misses 3897 3897
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
なぜかこちらのレポジトリでは改善しない🤔 |
nanasess
force-pushed
the
fix-ci
branch
2 times, most recently
from
606bfdb
to
2ae3d2a
Compare
一旦、 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL17 がリリースされたタイミングで GitHub Actions にエラーが発生している
PostgreSQL17 サーバーへ PostgreSQL17未満の psql で
\lを実行すると以 下のエラーが発生するwait-for-pgsql.sh で
\lを使用していたため、副作用の少ないSELECT 1に変更する.また、 docker compose のヘルスチェックが有効になるよう
condition: service_healthyを追加する