Use symfony/polyfill-php80 #1042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
+ Coverage 51.67% 51.70% +0.03%
==========================================
Files 80 80
Lines 10224 10217 -7
==========================================
Hits 5283 5283
+ Misses 4941 4934 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816
以下 Copilot actions のコメント
This pull request includes several changes to improve compatibility and clean up deprecated code. The most important changes include adding a new dependency to
composer.json, removing deprecated PHP compatibility functions, and updating the PHPStan configuration.Dependency updates:
composer.json: Addedsymfony/polyfill-php80to ensure compatibility with PHP 8.0. (composer.jsonL50-R51)Code cleanup:
data/class/SC_Initial.php: Removed thecompatPhpmethod and its call in theinitmethod, as it contained deprecated PHP compatibility functions that are no longer needed. ([1], [2])Configuration updates:
phpstan.neon.dist: Removed an unnecessary PHPStan error ignore rule related to inner named functions, as it is no longer applicable. ([phpstan.neon.distL41-L43](https://github.com/EC-CUBE/ec-cube2/pull/1042/files#diff-6f19df6a6307a48db0940e6897591fb08776d2db8a6134737aa708defdb5c92dL41-L43))