Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソース整形 配列末尾のカンマと閉じ括弧を改行する #1017 #1050

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

seasoftjapan
Copy link
Contributor

  • 手打ちで改行を追加。
  • VSCode で整形。
  • 関数呼び出しで、複数の引数の一部で可読性が悪い箇所は、一旦変数に収めた。
  • 一次元配列はケツカンマを削除して1行に収めた。
  • php-cs-fixer 実行。

fixed #1017

- 手打ちで改行を追加。
- VSCode で整形。
- 関数呼び出しで、複数の引数の一部で可読性が悪い箇所は、一旦変数に収めた。
- 一次元配列はケツカンマを削除して1行に収めた。
- php-cs-fixer 実行。
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 32.60870% with 31 lines in your changes missing coverage. Please review.

Project coverage is 51.67%. Comparing base (0d0a7b4) to head (80a7daf).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
data/class/api/SC_Api_Operation.php 0.00% 11 Missing ⚠️
data/class/api/SC_Api_Utils.php 0.00% 4 Missing ⚠️
data/class/helper/SC_Helper_DB.php 50.00% 4 Missing ⚠️
data/class/api/operations/CartAdd.php 0.00% 2 Missing ⚠️
data/class/api/operations/CartClear.php 0.00% 2 Missing ⚠️
data/class/api/operations/CartCreate.php 0.00% 2 Missing ⚠️
data/class/api/operations/CartGet.php 0.00% 2 Missing ⚠️
data/class/api/operations/CartModify.php 0.00% 2 Missing ⚠️
data/class/api/operations/GetVersion.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
- Coverage   51.72%   51.67%   -0.06%     
==========================================
  Files          80       80              
  Lines       10202    10224      +22     
==========================================
+ Hits         5277     5283       +6     
- Misses       4925     4941      +16     
Flag Coverage Δ
tests 51.67% <32.60%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seasoftjapan seasoftjapan merged commit 6d133f4 into master Nov 12, 2024
208 of 211 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ソース整形 配列末尾のカンマと閉じ括弧を改行する
2 participants