Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] refs #100 #278

Merged
merged 3 commits into from
May 7, 2020
Merged

[fix] refs #100 #278

merged 3 commits into from
May 7, 2020

Conversation

seasoftjapan
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 18, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 42.326% when pulling 3adb99e on seasoftjapan:#100 into 3ac54e0 on EC-CUBE:improve/php7.

@kazumiiiiiiiiiii kazumiiiiiiiiiii added this to the 2.17.0 milestone Jul 2, 2019
@chihiro-adachi
Copy link
Contributor

@seasoftjapan
#278 (review)

こちらご確認おねがいできますでしょうか。

@kiy0taka kiy0taka changed the base branch from improve/php7 to master October 23, 2019 01:39
@chihiro-adachi chihiro-adachi modified the milestones: 2.17.0, 2.17.1 Oct 29, 2019
@seasoftjapan @nanasess
Update data/class/pages/admin/products/LC_Page_Admin_Products_Product…
bd17e6c 
….php

Co-Authored-By: Kentaro Ohkouchi <nanasess@fsm.ne.jp>
nanasess
nanasess approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！

@seasoftjapan seasoftjapan merged commit 2fa7ff1 into EC-CUBE:master May 7, 2020
@okazy okazy mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanasess nanasess nanasess approved these changes

Assignees
No one assigned
Labels
bug discussion
Projects
None yet
Milestone
2.17.1
Development

Successfully merging this pull request may close these issues.
5 participants
@seasoftjapan @coveralls @chihiro-adachi @nanasess @kazumiiiiiiiiiii