Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] refs #101 SC_UploadFile::getFormFileList() 第1,2引数を省略可能とし、基本は省略する #280

Merged
merged 1 commit into from
May 7, 2020

Conversation

seasoftjapan
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 42.33% when pulling f22acae on seasoftjapan:#101 into 3ac54e0 on EC-CUBE:improve/php7.

Copy link
Contributor

@nobuhiko nobuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public function getFormFileList($temp_url = IMAGE_TEMP_URLPATH, $save_url = IMAGE_SAVE_URLPATH, $real_size = false)
って書けないですっけ?

@chihiro-adachi
Copy link
Contributor

@seasoftjapan
#280 (review)

こちらのコメントいかがでしょう?

@kiy0taka kiy0taka changed the base branch from improve/php7 to master October 23, 2019 01:40
@chihiro-adachi chihiro-adachi modified the milestones: 2.17.0, 2.17.1 Oct 29, 2019
@seasoftjapan
Copy link
Contributor Author

public function getFormFileList($temp_url = IMAGE_TEMP_URLPATH, $save_url = IMAGE_SAVE_URLPATH, $real_size = false)
って書けないですっけ?

それだと、第3引数のみ指定したいときに、
$objUpFile->getFormFileList(null, null, true);
のように書けないです。

@seasoftjapan
Copy link
Contributor Author

@seasoftjapan
#280 (review)

こちらのコメントいかがでしょう?

#280 (comment) で良かったですか?

@seasoftjapan seasoftjapan merged commit 9fd10a1 into EC-CUBE:master May 7, 2020
@nobuhiko
Copy link
Contributor

nobuhiko commented May 7, 2020

@seasoftjapan さん、自分でmergeするのは駄目です。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants