Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditorConfig の対応 #342

Merged
merged 2 commits into from
Dec 10, 2019
Merged

EditorConfig の対応 #342

merged 2 commits into from
Dec 10, 2019

Conversation

nanasess
Copy link
Contributor

  • EditorConfig に対応する

  • EditorConfig 対応 ec-cube3#61

  • 基本は indent_style = space, indent_size = 4

  • JavaScript, JSON, YAML ファイルは indent_size = 2

    • html 以下の JavaScript, 一部連携サービスの YAML ファイルは indent_size = 4

@nobuhiko
Copy link
Contributor

  • Workflows can't be executed on this repository. Please check your payment method or billing status.
    ?

@nanasess
Copy link
Contributor Author

なんかバグってるっぽいですね🐛
https://git.luolix.topmunity/t5/GitHub-Actions/GitHub-Actions-workflows-can-t-be-executed-on-this-repository/m-p/38153#M3236

@chihiro-adachi
Copy link
Contributor

@nobuhiko @nanasess
昔のプランで契約していて、GitHub Actionsが利用できないみたいです。
現プランへの移行もすぐには難しく、いったんGitHub Actionsは無効化させていただきました。

既にいただいているPRについては、他のCIが通っているかで確認していきます。

EC-CUBE/ec-cube#4392 (comment)

@chihiro-adachi chihiro-adachi added this to the 2.17.1 milestone Nov 26, 2019
This was referenced Nov 26, 2019
Merged
Merged
@chihiro-adachi chihiro-adachi merged commit d5746e6 into EC-CUBE:master Dec 10, 2019
@nanasess nanasess deleted the support-editorconfig branch October 3, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.17.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nanasess @nobuhiko @chihiro-adachi