prefilterTransform の後方互換処理 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefilterTransform の引数 $filename は, Smarty3 では絶対パスが入ってく るため, Smarty2 と同様にテンプレートディレクトリからの相対パスになるよ う修正
|
プラグインインストールの E2E テストを作成しないとテストできなさそうなので、後ほど作成します |
- xenial ではデフォルトの google-chrome-stable を使用する - trusty では --allow-unauthenticated を付与してインストールする
google-chrome-stable の GPG エラーを改善
|
prefilterTransform の E2E テストを追加しました |
nobuhiko
approved these changes
Jan 21, 2020
|
@nanasess ありがとうございます、マージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefilterTransform の引数 $filename は, Smarty3 では絶対パスが入ってくるため, 一部のプラグインで prefilterTransform が動作しない。
Smarty2 と同様にテンプレートディレクトリからの相対パスになるよう修正