Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

カテゴリに紐付いた商品が0となった場合に dtb_category_total_count が更新されない #125 #431

Merged
merged 11 commits into from
Mar 24, 2024
Merged

カテゴリに紐付いた商品が0となった場合に dtb_category_total_count が更新されない #125 #431

merged 11 commits into from
Mar 24, 2024

Conversation

seasoftjapan
Copy link
Contributor

@seasoftjapan seasoftjapan commented Dec 10, 2020 •
edited
Loading

商品0件の場合、dtb_category_count dtb_category_total_count に残さない。
変数名を整理。
配列を短縮構文で記述。

fixed #125

@seasoftjapan
カテゴリに紐付いた商品が0となった場合に dtb_category_total_count が更新されない EC-CUBE#125
9bdf208 
商品0件の場合、dtb_category_count dtb_category_total_count に残さない。
変数名を整理。
配列を短縮構文で記述。
@okazy okazy added this to the 2.17.2 milestone Feb 16, 2021
@nanasess
Copy link
Contributor

テストはこちらで別途作成しようと思います

@nanasess nanasess mentioned this pull request Oct 7, 2021
Open
3 tasks
@nanasess nanasess modified the milestones: 2.17.2, 2.17.3 Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.20%. Comparing base (bce476d) to head (b8c1141).

Files Patch % Lines
data/class/helper/SC_Helper_DB.php 95.83% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   55.21%   55.20%   -0.01%     
==========================================
  Files          75       75              
  Lines        8913     8900      -13     
==========================================
- Hits         4921     4913       -8     
+ Misses       3992     3987       -5
Flag Coverage Δ
tests 55.20% <95.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ji-eunsoo
Copy link
Contributor

テストコード追加予定

nanasess
nanasess approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess nanasess enabled auto-merge March 22, 2024 05:26
@nanasess nanasess merged commit aea89c3 into EC-CUBE:master Mar 24, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanasess nanasess nanasess approved these changes

Assignees
No one assigned
Labels
bug:Middle
Projects
None yet
Milestone
2.17.3
Development

Successfully merging this pull request may close these issues.

カテゴリに紐付いた商品が0となった場合に dtb_category_total_count が更新されない
5 participants
@seasoftjapan @nanasess @codecov-commenter @ji-eunsoo @okazy