Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#783 #784 CSS改善 (PC) #804

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Conversation

seasoftjapan
Copy link
Contributor

No description provided.

- CSS Nesting Module を使った実装 EC-CUBE#783
- CSS ファイルをまとめる EC-CUBE#784

```
cat \
html/user_data/packages/default/css/reset.css \
html/user_data/packages/default/css/common.css \
html/user_data/packages/default/css/contents.css \
html/user_data/packages/default/css/table.css \
html/user_data/packages/default/css/bloc.css \
html/user_data/packages/default/css/bloc_alpha.css \
html/user_data/packages/default/css/popup.css \
html/user_data/packages/default/css/print.css \
| sass-convert --indent=4 --from=css --to=scss \
> html/user_data/packages/default/style.css
```
目視で気になった点を調整した。
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d5a5b9) 55.38% compared to head (0b6e418) 55.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files          75       75           
  Lines        8908     8908           
=======================================
  Hits         4934     4934           
  Misses       3974     3974           
Flag Coverage Δ
tests 55.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

削除されたファイルを参照しているが未使用と思われるファイルを削除する。
@seasoftjapan seasoftjapan changed the title #783 #784 (PC) #783 #784 CSS改善 (PC) Dec 20, 2023
@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Jan 4, 2024
Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ji-eunsoo ji-eunsoo merged commit 4848672 into EC-CUBE:master Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants