Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2Eテストが頻繁に失敗するのを修正 #936

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jun 6, 2024

購入フローのE2Eテストで 0 ポイントの会員が生成されると先に進めなくなる模様
https://github.com/EC-CUBE/ec-cube2/blob/master/e2e-tests/pages/shopping/payment.page.ts#L72-L75

eccube2-fixture-generator で会員を生成する際は、必ず1ポイント以上付与するよう修正

@nanasess nanasess enabled auto-merge June 6, 2024 01:28
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.69%. Comparing base (8853c91) to head (079df26).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files          75       75           
  Lines        8905     8905           
=======================================
  Hits         4960     4960           
  Misses       3945     3945           
Flag Coverage Δ
tests 55.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seasoftjapan seasoftjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ docker compose exec -T ec-cube php -ddisplay_errors=1 data/vendor/bin/eccube eccube:fixtures:generate --products=5 --customers=10000 --orders=5
eccube_db=# select count(*) ,min(point), max(point) from dtb_customer;
 count | min | max
-------+-----+------
 10001 |   1 | 9997
(1 row)

@nanasess
Copy link
Contributor Author

nanasess commented Jun 6, 2024

MySQL8 の場合は data/config/config.php が生成される前にヘルスチェックが完了してしまうようなので、 data/config/config.php が生成されるまで待機するようにしました

@nanasess nanasess merged commit 1613626 into EC-CUBE:master Jun 6, 2024
90 checks passed
@nanasess nanasess deleted the bump-generator branch June 6, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants