-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2Eテストが頻繁に失敗するのを修正 #936
E2Eテストが頻繁に失敗するのを修正 #936
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #936 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 75 75
Lines 8905 8905
=======================================
Hits 4960 4960
Misses 3945 3945
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ docker compose exec -T ec-cube php -ddisplay_errors=1 data/vendor/bin/eccube eccube:fixtures:generate --products=5 --customers=10000 --orders=5
eccube_db=# select count(*) ,min(point), max(point) from dtb_customer;
count | min | max
-------+-----+------
10001 | 1 | 9997
(1 row)
MySQL8 の場合は data/config/config.php が生成される前にヘルスチェック が完了してしまうため
MySQL8 の場合は data/config/config.php が生成される前にヘルスチェックが完了してしまうようなので、 data/config/config.php が生成されるまで待機するようにしました |
購入フローのE2Eテストで 0 ポイントの会員が生成されると先に進めなくなる模様
https://github.com/EC-CUBE/ec-cube2/blob/master/e2e-tests/pages/shopping/payment.page.ts#L72-L75
eccube2-fixture-generator で会員を生成する際は、必ず1ポイント以上付与するよう修正