-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarty::addPluginsDir()
は非推奨になったため、Smarty::registerPlugin()
を使用するよう修正
#946
Conversation
nanasess
commented
Jun 18, 2024
•
edited
Loading
edited
- 合わせて修正 Fixes Smarty modifier に array_key_exists を追加 #914
- data/smarty_extends/block.marquee.php, data/smarty_extends/modifier.numeric_emoji.php はモバイルテンプレートが廃止されたため非推奨とする
89096ff
to
443dd2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
==========================================
+ Coverage 55.69% 55.72% +0.03%
==========================================
Files 75 75
Lines 8906 8913 +7
==========================================
+ Hits 4960 4967 +7
Misses 3946 3946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動作は問題無さそうです。ドキュメントで気になった点があるので、別途コメントします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data/class/SC_View.php への追記についても言及した方が良さそうに思いますが、いかがでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。こちらも記載しておきますね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seasoftjapan 対応しました!