Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

未使用定数 DB_CONNECT_ERROR を削除 #986

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

seasoftjapan
Copy link
Contributor

  • 定数定義されているのみで、使われていない。mtb_constants から移動する際に混入した様子。
  • DOWNFILE_NOT_FOUND と値が重複している。

- 定数定義されているのみで、使われていない。mtb_constants から移動する際に混入した様子。
- DOWNFILE_NOT_FOUND と値が重複している。
@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Aug 29, 2024
@seasoftjapan seasoftjapan self-assigned this Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (1301940) to head (83891f3).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files          75       75           
  Lines        8917     8917           
=======================================
  Hits         4961     4961           
  Misses       3956     3956           
Flag Coverage Δ
tests 55.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seasoftjapan seasoftjapan merged commit 09d6b60 into master Aug 29, 2024
177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants