Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

メール関連の PHPUnit 修正 #998

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

seasoftjapan
Copy link
Contributor

  • Docker Compose 構成でも PHPUnit のメール関連のテストを実行する。
    適用前後のテスト結果抜粋:
    -Tests: 1218, Assertions: 1433, Skipped: 17, Incomplete: 4.
    +Tests: 1218, Assertions: 1447, Skipped: 9, Incomplete: 4.
  • fixed SC_SendMailTest::testGetBackendParams() テスト重複 #997
    • 繰り返しを削除した。

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (fc5a36a) to head (49e834e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files          75       75           
  Lines        8917     8917           
=======================================
  Hits         4961     4961           
  Misses       3956     3956           
Flag Coverage Δ
tests 55.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seasoftjapan seasoftjapan merged commit 66445b3 into master Sep 9, 2024
178 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC_SendMailTest::testGetBackendParams() テスト重複
2 participants