Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pins numpy < 2 #67

Merged
merged 2 commits into from
Jun 19, 2024
Merged

pins numpy < 2 #67

merged 2 commits into from
Jun 19, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Jun 19, 2024

PR summary

pins numpy < 2 until we can determine why the tests fail with numpy >= 2

Todos

  • make sure CI passes

Test plan

Just CI

Breaking changes

None

Related Issues

closes #66

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (5b72566) to head (e1f7b33).
Report is 2 commits behind head on main.

Current head e1f7b33 differs from pull request most recent head bdc8745

Please upload reports for the commit bdc8745 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files           7        7           
  Lines         410      410           
  Branches       71       71           
=======================================
  Hits          340      340           
  Misses         54       54           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes merged commit 17fe24d into main Jun 19, 2024
4 checks passed
@jmbhughes jmbhughes deleted the pin-numpy branch June 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failure in CI from numpy 2.0
1 participant