Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid type union problems in 3.9 #73

Merged
merged 4 commits into from
Jun 27, 2024
Merged

avoid type union problems in 3.9 #73

merged 4 commits into from
Jun 27, 2024

Conversation

jmbhughes
Copy link
Member

PR summary

Import from __future__ to mitigate type union hint problems

Todos

None

Test plan

Adds 3.9 to the CI

Breaking changes

None

Related Issues

None

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (839f206) to head (2482075).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   82.36%   82.53%   +0.16%     
==========================================
  Files           7        7              
  Lines         414      418       +4     
  Branches       73       73              
==========================================
+ Hits          341      345       +4     
  Misses         56       56              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes merged commit 33f6097 into main Jun 27, 2024
7 checks passed
@jmbhughes jmbhughes deleted the allow-py39 branch June 27, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant