Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QED lookup tables generator/reader in /Tools #3137
Add QED lookup tables generator/reader in /Tools #3137
Changes from 48 commits
daa3dcd
2eab133
dea483e
4c62c5b
b57cfea
ac3b2a7
cd5122a
7a8f172
4a31a8e
62b0a1e
887db9a
6b6c401
0c9a783
b048fa6
ee6c16f
5faee75
d58869e
cca3b9a
af21b32
2b7338e
e8155fa
69c70ad
3eb9744
a139a0c
41456d1
5f85984
ae7a1e4
713333c
cc17530
28ad0bb
22d2065
91ad32e
ca421d2
f7b6b8e
bd77365
5d4c423
d7c7e07
f5fc6a7
4ebb3a9
e2898fc
a3311b5
c90133e
bf1d942
bc81124
30464b1
74a00d9
2aa0342
d7c3632
3be126e
c45ffa7
172f859
6fa5a44
632bf79
2123ca7
bab799c
86fee9f
fd3f7da
ceddaed
1913bb2
4e18008
2594a41
dd1552f
1aedaa5
f9a6128
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.rst
ending not needed :)#4804
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be useful for users to give recommended table parameters in this file (there are a lot of parameters and it's not trivial to choose them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right... we need to properly document everything related to the QED module... I promise that I will work on that starting from January 2023!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this library used anywhere else?
If you like, generalize it and make it part of the ABLASTR utils? (as a follow-up PR?)