[WIP] Update AMReX #3186
Closed
[WIP] Update AMReX #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to pull in a new feature to ABLASTR for inputs control that just landed in AMReX. Needed for ImpactX.
ax3l
added
the
component: third party
WeiqunZhang
approved these changes
Jun 16, 2022
|
Oh, checksum change from the update? |
|
If it helps, these are the tests that failed:
@PhilMiller Could these checksum changes be related to AMReX-Codes/amrex#2814? |
|
Might need AMReX-Codes/amrex#2839 ? I will try to run with that commit. |
|
CI of this current PR is now running on AMReX-Codes/amrex#2839 PR #3192 will replace this PR once the above AMReX PR is merged. |
|
Replaced by #3192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to pull in a new feature to ABLASTR for inputs control that just landed in AMReX. Needed for ImpactX Python: