CMake: 3.20+ #3196
Merged
CMake: 3.20+ #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely needs AMReX-Codes/amrex#2849 |
5 tasks
|
@ax3l Would you have time to rebase this PR? |
We already use this version in ImpactX. The main reason is a severe simplifcation of CMake CUDA search logic that we can rely on. X-Ref.: https://github.com/AMReX-Codes/amrex/blob/2d931f63cb4d611d0d23d694726889647f8a482d/Tools/CMake/AMReXParallelBackends.cmake#L55
|
Rebased now :) |
dpgrote
pushed a commit
to RemiLehe/WarpX
that referenced
this pull request
Jul 30, 2022
We already use this version in ImpactX. The main reason is a severe simplifcation of CMake CUDA search logic that we can rely on. X-Ref.: https://github.com/AMReX-Codes/amrex/blob/2d931f63cb4d611d0d23d694726889647f8a482d/Tools/CMake/AMReXParallelBackends.cmake#L55
kngott
pushed a commit
to kngott/WarpX
that referenced
this pull request
Sep 9, 2022
``` error ECP-WarpX#3196-D: The enclosing parent function ("ComputeEdgeLengths") for an extended __device__ lambda cannot have private or protected access within its class ``` For: - `ComputeEdgeLengths` - `ComputeFaceAreas` - `ScaleEdges` - `ScaleAreas`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use this version in ImpactX. The main reason is a severe simplification of CMake CUDA search logic that we can rely on.
X-Ref.:
https://github.com/AMReX-Codes/amrex/blob/2d931f63cb4d611d0d23d694726889647f8a482d/Tools/CMake/AMReXParallelBackends.cmake#L55