Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMReX/PICSAR: Weekly Update #3412

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 19, 2022

Weekly update to latest AMReX.
Weekly update to latest PICSAR (no changes).

./Tools/Release/updateAMReX.py
./Tools/Release/updatePICSAR.py

@ax3l ax3l added the component: third party Changes in WarpX that reflect a change in a third-party library label Sep 19, 2022
@ax3l ax3l requested a review from EZoni September 19, 2022 16:09
@ax3l ax3l marked this pull request as ready for review September 19, 2022 16:09
@EZoni EZoni enabled auto-merge (squash) September 19, 2022 17:11
@ax3l ax3l assigned atmyers and WeiqunZhang and unassigned EZoni Sep 19, 2022
@ax3l
Copy link
Member Author

ax3l commented Sep 19, 2022

@WeiqunZhang @atmyers this week's update of AMReX changes WarpX checksums. Do you have time to investigate this?

  • 2D: background_mcc_dp_psp (position)
  • 3D: pml_psatd_dive_divb_cleaning (rho)
  • SP: reduced_diags_single_precision (momentum)

@ax3l
Copy link
Member Author

ax3l commented Sep 19, 2022

@WeiqunZhang
Copy link
Member

The failure of 3D: pml_psatd_dive_divb_cleaning (rho) was due to the change in amrex::Geometry::outsideRoundOffDomain.

- [x] 2D: `background_mcc_dp_psp`
- [x] 3D: `pml_psatd_dive_divb_cleaning`
- [x] SP: `reduced_diags_single_precision`
@ax3l
Copy link
Member Author

ax3l commented Sep 26, 2022

2D: background_mcc_dp_psp (position) - @peterscherpelz:

That seems fine to me, I don't have any reason a small change like that would matter. Thanks for checking 

SP: reduced_diags_single_precision (momentum) - @RemiLehe:

I think that we can also reset the test reduced_diags_single_precision:
the errors are consistent with potentially having a slightly different number of particles in the box, due to the change in the condition that removes particles.

3D: pml_psatd_dive_divb_cleaning (rho) - @EZoni:

That test has three different lasers, polarized in three different directions, and I think it was added to show that using div cleaning in the PML (together with div cleaning in the valid domain) helps mitigate some instability that was otherwise growing at the domain-PML interface. This is described in more detail in PR [#1600](https://github.com/ECP-WarpX/WarpX/pull/1600), where the test was originally introduced.

-> @RemiLehe & @EZoni : ok to update checksum

@ax3l
Copy link
Member Author

ax3l commented Sep 26, 2022

I did reset the three checksums with AMReX from a week ago. This passed locally.

After that, I pushed the latest AMReX change from this week on the PR.

@ax3l ax3l disabled auto-merge September 26, 2022 23:05
@ax3l ax3l enabled auto-merge (squash) September 26, 2022 23:06
@ax3l ax3l disabled auto-merge September 26, 2022 23:07
@ax3l ax3l enabled auto-merge (squash) September 26, 2022 23:07
@ax3l ax3l merged commit 1b9ba80 into ECP-WarpX:development Sep 28, 2022
@ax3l ax3l deleted the topic-amrexWeekly branch October 10, 2022 18:25
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 22, 2022
* AMReX: Weekly Update

* Roundoff Domain: Reset Checksums:

- [x] 2D: `background_mcc_dp_psp`
- [x] 3D: `pml_psatd_dive_divb_cleaning`
- [x] SP: `reduced_diags_single_precision`

* AMReX: Weekly Update

Fix ECP-WarpX#3429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants