Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMReX/PICSAR: Weekly Update #3822

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 9, 2023

Weekly update to latest AMReX.
Weekly update to latest PICSAR (no changes).

./Tools/Release/updateAMReX.py
./Tools/Release/updatePICSAR.py

Notes

@ax3l ax3l added the component: third party Changes in WarpX that reflect a change in a third-party library label Apr 9, 2023
@ax3l ax3l requested review from atmyers and WeiqunZhang April 9, 2023 20:16
@ax3l ax3l mentioned this pull request Apr 10, 2023
1 task
@ax3l
Copy link
Member Author

ax3l commented Apr 11, 2023

a few checks that raise checksum differences:

  • hard_edged_quadrupoles (3D)
Benchmark: [lev=0,Ex] 9.882421125782868e-06
Plotfile : [lev=0,Ex] 9.882421146615367e-06
Benchmark: [lev=0,Ey] 1.044026102498192e-05
Plotfile : [lev=0,Ey] 1.044026104671425e-05
Benchmark: [lev=0,Ez] 1.003739698556440e-05
Plotfile : [lev=0,Ez] 1.003739697324731e-05
  • pml_psatd_dive_divb_cleaning (3D)
Benchmark: [lev=0,Bx] 1.482006333945839e-07
Plotfile : [lev=0,Bx] 1.240175732139287e-06
Benchmark: [lev=0,By] 1.482051585061588e-07
Plotfile : [lev=0,By] 1.219308776050087e-06
Benchmark: [lev=0,Bz] 1.495470407235984e-07
Plotfile : [lev=0,Bz] 1.229402125805917e-06
Benchmark: [lev=0,Ex] 1.178979338985698e+01
Plotfile : [lev=0,Ex] 6.142609646226940e+02
Benchmark: [lev=0,Ey] 1.178688476447710e+01
Plotfile : [lev=0,Ey] 6.224773198394323e+02
Benchmark: [lev=0,Ez] 1.177011081446856e+01
Plotfile : [lev=0,Ez] 6.135902829786862e+02
Benchmark: [lev=0,rho] 4.903696256562049e-05
Plotfile : [lev=0,rho] 4.903696525896805e-05
  • background_mcc_dp_psp (2D)
Benchmark: [electrons,particle_momentum_z] 2.810005821001351e-19
Plotfile : [electrons,particle_momentum_z] 2.810005842534688e-19
Benchmark: [electrons,particle_position_y] 9.356698625905589e+02
Plotfile : [electrons,particle_position_y] 9.356698666088197e+02
  • reduced_diags_single_precision (SP)
    also very small stuff...

@ax3l
Copy link
Member Author

ax3l commented Apr 11, 2023

@WeiqunZhang I don't understand the relatively large changes in pml_psatd_dive_divb_cleaning... This test does not even have particles.

@ax3l ax3l requested review from EZoni and RemiLehe April 11, 2023 02:02
@RemiLehe
Copy link
Member

@ax3l This test does have particles, I think, since the laser is emitted by an antenna made of macroparticles with a prescribed motion.

@ax3l
Copy link
Member Author

ax3l commented Apr 11, 2023

Oh I forgot again, ok that makes sense (including the rho).

Should we print the fields before and after to see it still makes sense? There is a significantly larger change in the fields for this one, concerning me the antenna might have changed now or the box might be too small of the initialized laser in the test.

@ax3l
Copy link
Member Author

ax3l commented Apr 11, 2023

Updating once more to include AMReX-Codes/amrex#3248

@ax3l
Copy link
Member Author

ax3l commented Apr 12, 2023

That test with the larger change in checksum (pml_psatd_dive_divb_cleaning) has a couple of warnings

* --> [!  ] [Algorithms] [raised once]
*     The chosen current deposition algorithm does not guarantee charge
*     conservation, and no additional current correction algorithm is activated
*     in order to compensate for that. Lack of charge conservation may
*     negatively affect the results of the simulation.
*     @ Raised by: ALL
*
* --> [!  ] [PML] [raised once]
*     Using PSATD together with PML may lead to instabilities if the plasma
*     touches the PML region. It is recommended to leave enough empty space
*     between the plasma boundary and the PML region.
*     @ Raised by: ALL

and might be too small for the sim box.

Don't really know what to make of it.
Untitled.zip

@EZoni as main author of the test, what is the expected output it checks? :) https://github.com/ECP-WarpX/WarpX/commits/development/Examples/Tests/pml/inputs_3d

@ax3l
Copy link
Member Author

ax3l commented Apr 15, 2023

In order to go forward, I would merge w/o the pml_psatd_dive_divb_cleaning test being fully understood. We thing the laser antenna is too wide but have not a lot of time to dig deeper into it rn.

@ax3l ax3l merged commit 742af75 into ECP-WarpX:development Apr 17, 2023
@ax3l ax3l deleted the topic-amrexWeekly branch April 17, 2023 01:14
lucafedeli88 pushed a commit to lucafedeli88/WarpX that referenced this pull request Apr 21, 2023
* AMReX: Weekly Update

* AMReX: Include Fix Roundoff Domain 3247

* Reset Benchmarks

* AMReX: Include PR 3248

* Update Checksums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants