Fix: Ablastr PoissonSolver Constant #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen in ImpactX:
```
build/_deps/fetchedablastr-src/Source/ablastr/fields/PoissonSolver.H:163:31: error: use of undeclared identifier 'PhysConst'
rho[lev]->mult(-1._rt/PhysConst::ep0); // TODO: when do we "un-multiply" this? We need to document this side-effect!
^
```
ax3l
added
bug
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Jul 18, 2023
Workaround for ECP-WarpX/WarpX#4090 in ABLASTR 23.07
ax3l
added a commit
to ECP-WarpX/impactx
that referenced
this pull request
Jul 18, 2023
* Release 23.07
Prepare the July release of ImpactX.
* FIx: PoissonSolve.cpp Constant
```
impactx/src/particles/spacecharge/PoissonSolve.cpp:106:36: error: use of undeclared identifier 'PhysConst'
rho[lev].mult(-1._rt * PhysConst::ep0);
^
```
* [Workaround] ABLASTR 23.07 Poisson eps0
Workaround for
ECP-WarpX/WarpX#4090
in ABLASTR 23.07
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Jul 18, 2023
Remove the workaround for ECP-WarpX/WarpX#4090
1 task
EZoni
reviewed
Jul 18, 2023
| @@ -160,7 +160,8 @@ computePhi (amrex::Vector<amrex::MultiFab*> const & rho, | |||
| // scale rho appropriately; also determine if rho is zero everywhere | |||
| amrex::Real max_norm_b = 0.0; | |||
| for (int lev=0; lev<=finest_level; lev++) { | |||
| rho[lev]->mult(-1._rt/PhysConst::ep0); // TODO: when do we "un-multiply" this? We need to document this side-effect! | |||
| using namespace ablastr::constant::SI; | |||
There was a problem hiding this comment.
Does the using-declaration need to be inside the for loop over levels?
There was a problem hiding this comment.
I would suggest placing the using declaration at the beginning of the function rather then in the for loop.
There was a problem hiding this comment.
The using declaration is performance neutral and the only type we need is inside this loop. Thus, I would not pollute the whole scope of the body of the function just yet and keep it localized here.
lucafedeli88
approved these changes
Jul 20, 2023
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Aug 9, 2023
Remove the workaround for ECP-WarpX/WarpX#4090
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Aug 9, 2023
Remove the workaround for ECP-WarpX/WarpX#4090
ax3l
added a commit
to ECP-WarpX/impactx
that referenced
this pull request
Aug 11, 2023
* Release 23.08 Prepare the August release of ImpactX. * PoissonSolve: Remove ABLASTR Workaround Remove the workaround for ECP-WarpX/WarpX#4090 * Examples: New AMReX Multi-Line Continuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in ImpactX: