Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFT-based Poisson solver follow-up #4945

Merged
merged 6 commits into from
May 31, 2024
Merged

Conversation

aeriforme
Copy link
Member

This follows-up PR #4648 as per @ax3l's requests here.

@aeriforme aeriforme requested review from ax3l and RemiLehe May 22, 2024 19:31
@aeriforme aeriforme added component: electrostatic electrostatic solver enhancement New feature or request component: ABLASTR components shared with other PIC codes labels May 22, 2024
@RemiLehe RemiLehe self-assigned this May 29, 2024
@ax3l ax3l self-assigned this May 29, 2024
Source/ablastr/fields/PoissonSolver.H Outdated Show resolved Hide resolved
Source/ablastr/fields/PoissonSolver.H Outdated Show resolved Hide resolved
aeriforme and others added 3 commits May 30, 2024 18:38
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's perfect!

@ax3l ax3l enabled auto-merge (squash) May 31, 2024 02:55
@ax3l ax3l merged commit bfffedf into ECP-WarpX:development May 31, 2024
45 checks passed
Haavaan pushed a commit to Haavaan/WarpX that referenced this pull request Jun 5, 2024
* changed  2

* add assert to check fft compilation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Source/ablastr/fields/PoissonSolver.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/ablastr/fields/PoissonSolver.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
@ax3l ax3l mentioned this pull request Jul 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ABLASTR components shared with other PIC codes component: electrostatic electrostatic solver enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants