-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fix fluctuations in collisionXZ
checksums
#5132
CI: fix fluctuations in collisionXZ
checksums
#5132
Conversation
308e355
to
e76c681
Compare
collisionXZ
checksumscollisionXZ
checksums
e76c681
to
3744e6c
Compare
collisionXZ
checksumscollisionXZ
test
6509b87
to
fe3b813
Compare
collisionXZ
testcollisionXZ
checksums
That parameter should be set here already: WarpX/Regression/prepare_file_ci.py Line 86 in 502e5ea
|
fe3b813
to
74a8cf4
Compare
That's right, thanks for pointing it out. I always forget that we set input parameters in three different places at the moment. For now I'm just keeping this PR open (now it simply increases the relative tolerance for the checksums) until the next meeting where this issue will be discussed. |
collisionXZ
checksumscollisionXZ
checksums
Since |
I'm afraid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me for now.
@RemiLehe @JustinRayAngus what do you think, shall we use this for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is good to do until the underlying issue with the collision tests can be sorted out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve. What's different between these two tests and the other tests that use Coulomb collisions?
We don't understand that yet... Maybe less particles per cell or per simulation and thus worse statistics? |
In #5126 I see that
Notable differences in runners:
|
Follow-up to ECP-WarpX#5132
Follow-up to ECP-WarpX#5132
Trying to see if we can get under control the fluctuations observed in the checksums of the
collisionXZ
test.